September 02 2010 14:19:35
Navigation
IRC Channel
Want to chat?
Join our IRC channel at:
irc.freenode.net #phpfusion

Freenode Webchat

Free IRC Clients: Wikipedia
Support Sites
Donate
View Thread
PHP-Fusion » PHP-Fusion 7 Support » v7.01.00 Testing and reporting
 Print Thread
[CLOSED] PHP-Fusion v7.01 RC3 Bug Reporting
starefossen
PHP-Fusion v7.01 Release Candidate 3
We are definitely closing in on release for PHP-Fusion v7.01. The RC3 release has a lot of changes we have been working really hard since we first released RC2. Incredible work from everyone.

Important: RC3 requires a Database Update which is included in db_updates/db_update 10-06-09.txt

Download source  GeSHi: PHP
  1. <?php
  2. // Alter news table and add medium image field
  3. $result = dbquery("ALTER TABLE ".DB_NEWS." ADD news_image_t2 VARCHAR(100) NOT NULL DEFAULT '' AFTER news_image_t1");
  4.  
  5. // Alter tables and add hidden fields
  6. $result = dbquery("ALTER TABLE ".DB_COMMENTS." ADD comment_hidden TINYINT(1) UNSIGNED NOT NULL DEFAULT '0'");
  7. $result = dbquery("ALTER TABLE ".DB_SHOUTBOX." ADD shout_hidden TINYINT(1) UNSIGNED NOT NULL DEFAULT '0'");
  8. $result = dbquery("ALTER TABLE ".DB_THREADS." ADD thread_hidden TINYINT(1) UNSIGNED NOT NULL DEFAULT '0'");
  9. $result = dbquery("ALTER TABLE ".DB_POSTS." ADD post_hidden TINYINT(1) UNSIGNED NOT NULL DEFAULT '0'");
  10.  
  11. // Insert new settings
  12. $result = dbquery("INSERT INTO ".DB_SETTINGS." (settings_name, settings_value) VALUES ('news_photo_w', '400')");
  13. $result = dbquery("INSERT INTO ".DB_SETTINGS." (settings_name, settings_value) VALUES ('news_photo_h', '300')");
  14. $result = dbquery("INSERT INTO ".DB_SETTINGS." (settings_name, settings_value) VALUES ('news_image_frontpage', '0')");
  15. $result = dbquery("INSERT INTO ".DB_SETTINGS." (settings_name, settings_value) VALUES ('news_image_readmore', '0')");
  16. $result = dbquery("INSERT INTO ".DB_SETTINGS." (settings_name, settings_value) VALUES ('deactivation_action', '0')");
  17.  
  18. // Update admin settings pages
  19. $result = dbquery("SELECT * FROM ".DB_ADMIN." WHERE admin_page='4'");
  20. while ($data = dbarray($result)) {
  21. $newname = str_replace(" Settings", "", $data['admin_title']);
  22. $result2 = dbquery("UPDATE ".DB_ADMIN." SET admin_title='".$newname."' WHERE admin_id='".$data['admin_id']."'");
  23. }
  24. ?>
Parsed in 0.624 seconds, using GeSHi 1.0.7.20

Edited by starefossen on 03-08-2010 23:58
PHP-Fusion Development Team Leader
PHP-Fusion Codex - The complete reference to PHP-Fusion!
 
http://code.starefossen.com
HobbyMan
BUG REPORTS ONLY! Features requests are locked!
 
http://www.phpnuclear.com/
WEC
administration\comments.php

Missing third argument in profile_link()

Find:
Download source  Code
echo "<span class='slink'>".profile_link($data['comment_name'], $data['user_name'])."</span>";




Replace with:
Download source  Code
echo "<span class='slink'>".profile_link($data['comment_name'], $data['user_name'],  $data['user_status'])."</span>";


 
WEC
administration/db_backup.php

Warnings:

Warning: opendir(../administration/db_backups/) [function.opendir]: failed to open dir: No such file or directory in U:\www\701rc3\maincore.php on line 712

Warning: readdir(): supplied argument is not a valid Directory resource in U:\www\701rc3\maincore.php on line 713

Warning: closedir(): supplied argument is not a valid Directory resource in U:\www\701rc3\maincore.php on line 724


Solution:

Create folder administration\db_backups
 
starefossen
@WEC: profile_link() error fixed in revision 1655. DB Backup admin error fixed in revision 1657. Thanks for reporting this!
PHP-Fusion Development Team Leader
PHP-Fusion Codex - The complete reference to PHP-Fusion!
 
http://code.starefossen.com
WEC
Your welcome,

submit.php

Most <input type=.... are missing <label></label>
 
starefossen
@WEC: Thanks again. Fixed in revision 1658; added the <label> tag to all checkboxes in submit.php.
Edited by starefossen on 11-06-2010 15:39
PHP-Fusion Development Team Leader
PHP-Fusion Codex - The complete reference to PHP-Fusion!
 
http://code.starefossen.com
WEC
print.php doesn't validate according to W3C.

Find:
Download source  Code
echo "<html>\n<head>\n";
echo "<title>".$settings['sitename']."</title>\n";




Reolace with:
Download source  Code
echo "<html xmlns='http://www.w3.org/1999/xhtml' xml:lang='".$locale['xml_lang']."' lang='".$locale['xml_lang']."'>\n";
echo "<head>\n<title>".$settings['sitename']."</title>\n";




Find:
Download source  Code
         if ($news_extended) { echo "<hr />\n<strong>".$locale['402']."</strong>\n<hr>\n$news_extended\n"; }




Replace with:
Download source  Code
         if ($news_extended) { echo "<hr />\n<strong>".$locale['402']."</strong>\n<hr />\n$news_extended\n"; }


 
WEC
administration\news.php

Notices:

Notice: Undefined variable: news_image_t2 in U:\www\701rc3\administration\news.php on line 302

Delete
Notice: Undefined variable: news_image_t2 in U:\www\701rc3\administration\news.php on line 306


Solution.

Around line 199 find:
Download source  Code
$news_image_t1 = (isset($_POST['news_image_t1']) ? $_POST['news_image_t1'] : "");




Add below it:
Download source  Code
$news_image_t2 = (isset($_POST['news_image_t2']) ? $_POST['news_image_t2'] : "");


 
WEC
administration\submissions.php

Notice on view submission:

Notice: Undefined index: user_status in U:\www\701rc3\administration\submissions.php on line 241


Solution.

Find:
Download source  Code
      $result = dbquery(
         "SELECT ts.*, tu.user_id, tu.user_name, tu.user_level FROM ".DB_SUBMISSIONS." ts
         LEFT JOIN ".DB_USERS." tu ON ts.submit_user=tu.user_id
         WHERE submit_id='".$_GET['submit_id']."'"
      );




Replace with:
Download source  Code
      $result = dbquery(
         "SELECT ts.*, tu.user_id, tu.user_name, tu.user_level, tu.user_status FROM ".DB_SUBMISSIONS." ts
         LEFT JOIN ".DB_USERS." tu ON ts.submit_user=tu.user_id
         WHERE submit_id='".$_GET['submit_id']."'"
      );




Same changes required for view submitted articles and submitted photos.
Edited by WEC on 11-06-2010 17:34
 
Fangree_Craig
Good Work WEC your doing really good at spotting these errors.
| Fangree Productions - Mods and Themes for PHP-Fusion 7 |
 
starefossen
@WEC: Thanks for excellent work. All the reported errors are fixed in revision 1662.
PHP-Fusion Development Team Leader
PHP-Fusion Codex - The complete reference to PHP-Fusion!
 
http://code.starefossen.com
gh0st2k
Hi, here are some proposals to replace the "SELECT * QUERIES" (only BASEDIR).
There are a lot of "SELECT *" Queries in the admin section, i try to post some fixes for them.
gh0st2k attached the following file:
fusion_query.rar
Edited by gh0st2k on 13-06-2010 12:52
 
kneekoo
Very good list, gh0st2k! Thank you. Wink By the way, did you manually look for the "SELECT *" queries or you used a file searching tool?
Come visit PHP-Fusion Romania
 
gh0st2k
Search and highlite Wink
h.imagehost.org/0833/select.png
 
gh0st2k
and here is the next list...
gh0st2k attached the following file:
fusion_admin_query.rar
 
MvE Designs
looks like gh0st2k is doing a good job Wink
 
starefossen
gh0st2k Nice, good work. Will be adding those and submit them with a bunch of other bug fixes to the SVN later tonight. Keep up the good work!
PHP-Fusion Development Team Leader
PHP-Fusion Codex - The complete reference to PHP-Fusion!
 
http://code.starefossen.com
MaWe4585
I get

Notice: Undefined index: user_status in E:\xampp\htdocs\phpfusion\administration\submissions.php on line 241

when i view submitted news submission in admin-module

edit: i tested a bit more:

Notice: Undefined index: user_status in E:\xampp\htdocs\phpfusion\administration\submissions.php on line 325

when i view submitted article submision

Notice: Undefined index: user_status in E:\xampp\htdocs\phpfusion\administration\submissions.php on line 427

when i view submitted photo submission
Edited by MaWe4585 on 16-06-2010 16:01
 
starefossen
@MaWe4585: Thanks for reporting this, it has been fixed in latest SVN revision and will be present in next Release Candidate.
PHP-Fusion Development Team Leader
PHP-Fusion Codex - The complete reference to PHP-Fusion!
 
http://code.starefossen.com
Jump to Forum:
Login
Username

Password



Not a member yet?
Click here to register.

Forgotten your password?
Request a new one here.
Member Poll
Which PHP version are you using?

4.x or older
4.x or older
7% [24 Votes]

5.0.x
5.0.x
4% [15 Votes]

5.1.x
5.1.x
3% [11 Votes]

5.2.x
5.2.x
27% [96 Votes]

5.3.x or newer
5.3.x or newer
59% [206 Votes]

Votes: 352
You must login to vote.
Started: 15 Jun 2010 23:49:52

Polls Archive
RSS Feeds
- PHP-Fusion News
- SF File Releases
- SF News Releases
Render time: 1.69 seconds - 24 Queries 72,519,199 unique visits