|
[CLOSED] PHP-Fusion v7.01 RC3 Bug Reporting
|
| starefossen |
Posted on 10-06-2010 23:18
|

Super Admin

Posts: 591
Joined: 09.02.06
|
PHP-Fusion v7.01 Release Candidate 3
We are definitely closing in on release for PHP-Fusion v7.01. The RC3 release has a lot of changes we have been working really hard since we first released RC2. Incredible work from everyone.
Important: RC3 requires a Database Update which is included in db_updates/db_update 10-06-09.txt
GeSHi: PHP<?php // Alter news table and add medium image field $result = dbquery("ALTER TABLE ".DB_NEWS." ADD news_image_t2 VARCHAR(100) NOT NULL DEFAULT '' AFTER news_image_t1"); // Alter tables and add hidden fields $result = dbquery("ALTER TABLE ".DB_COMMENTS." ADD comment_hidden TINYINT(1) UNSIGNED NOT NULL DEFAULT '0'"); $result = dbquery("ALTER TABLE ".DB_SHOUTBOX." ADD shout_hidden TINYINT(1) UNSIGNED NOT NULL DEFAULT '0'"); $result = dbquery("ALTER TABLE ".DB_THREADS." ADD thread_hidden TINYINT(1) UNSIGNED NOT NULL DEFAULT '0'"); $result = dbquery("ALTER TABLE ".DB_POSTS." ADD post_hidden TINYINT(1) UNSIGNED NOT NULL DEFAULT '0'"); // Insert new settings $result = dbquery("INSERT INTO ".DB_SETTINGS." (settings_name, settings_value) VALUES ('news_photo_w', '400')"); $result = dbquery("INSERT INTO ".DB_SETTINGS." (settings_name, settings_value) VALUES ('news_photo_h', '300')"); $result = dbquery("INSERT INTO ".DB_SETTINGS." (settings_name, settings_value) VALUES ('news_image_frontpage', '0')"); $result = dbquery("INSERT INTO ".DB_SETTINGS." (settings_name, settings_value) VALUES ('news_image_readmore', '0')"); $result = dbquery("INSERT INTO ".DB_SETTINGS." (settings_name, settings_value) VALUES ('deactivation_action', '0')"); // Update admin settings pages $result = dbquery("SELECT * FROM ".DB_ADMIN." WHERE admin_page='4'"); while ($data = dbarray($result)) { $newname = str_replace(" Settings", "", $data['admin_title']); $result2 = dbquery("UPDATE ".DB_ADMIN." SET admin_title='".$newname."' WHERE admin_id='".$data['admin_id']."'"); } ?>
Parsed in 0.624 seconds, using GeSHi 1.0.7.20
Edited by starefossen on 03-08-2010 23:58
PHP-Fusion Development Team Leader
PHP-Fusion Codex - The complete reference to PHP-Fusion! |
| |
|
|
| HobbyMan |
Posted on 11-06-2010 11:04
|

Super Admin

Posts: 1100
Joined: 24.03.07
|
BUG REPORTS ONLY! Features requests are locked! |
| |
|
|
| WEC |
Posted on 11-06-2010 14:51
|
Fusioneer

Posts: 1418
Joined: 22.10.05
|
administration\comments.php
Missing third argument in profile_link()
Find:
Codeecho "<span class='slink'>".profile_link($data['comment_name'], $data['user_name'])."</span>";
Replace with:
Codeecho "<span class='slink'>".profile_link($data['comment_name'], $data['user_name'], $data['user_status'])."</span>";
|
| |
|
|
| WEC |
Posted on 11-06-2010 15:09
|
Fusioneer

Posts: 1418
Joined: 22.10.05
|
administration/db_backup.php
Warnings:
Warning: opendir(../administration/db_backups/) [function.opendir]: failed to open dir: No such file or directory in U:\www\701rc3\maincore.php on line 712
Warning: readdir(): supplied argument is not a valid Directory resource in U:\www\701rc3\maincore.php on line 713
Warning: closedir(): supplied argument is not a valid Directory resource in U:\www\701rc3\maincore.php on line 724
Solution:
Create folder administration\db_backups |
| |
|
|
| starefossen |
Posted on 11-06-2010 15:27
|

Super Admin

Posts: 591
Joined: 09.02.06
|
@WEC: profile_link() error fixed in revision 1655. DB Backup admin error fixed in revision 1657. Thanks for reporting this!
PHP-Fusion Development Team Leader
PHP-Fusion Codex - The complete reference to PHP-Fusion! |
| |
|
|
| WEC |
Posted on 11-06-2010 15:32
|
Fusioneer

Posts: 1418
Joined: 22.10.05
|
Your welcome,
submit.php
Most <input type=.... are missing <label></label> |
| |
|
|
| starefossen |
Posted on 11-06-2010 15:38
|

Super Admin

Posts: 591
Joined: 09.02.06
|
@WEC: Thanks again. Fixed in revision 1658; added the <label> tag to all checkboxes in submit.php.
Edited by starefossen on 11-06-2010 15:39
PHP-Fusion Development Team Leader
PHP-Fusion Codex - The complete reference to PHP-Fusion! |
| |
|
|
| WEC |
Posted on 11-06-2010 16:30
|
Fusioneer

Posts: 1418
Joined: 22.10.05
|
print.php doesn't validate according to W3C.
Find:
Codeecho "<html>\n<head>\n";
echo "<title>".$settings['sitename']."</title>\n";
Reolace with:
Codeecho "<html xmlns='http://www.w3.org/1999/xhtml' xml:lang='".$locale['xml_lang']."' lang='".$locale['xml_lang']."'>\n";
echo "<head>\n<title>".$settings['sitename']."</title>\n";
Find:
Code if ($news_extended) { echo "<hr />\n<strong>".$locale['402']."</strong>\n<hr>\n$news_extended\n"; }
Replace with:
Code if ($news_extended) { echo "<hr />\n<strong>".$locale['402']."</strong>\n<hr />\n$news_extended\n"; }
|
| |
|
|
| WEC |
Posted on 11-06-2010 16:49
|
Fusioneer

Posts: 1418
Joined: 22.10.05
|
administration\news.php
Notices:
Notice: Undefined variable: news_image_t2 in U:\www\701rc3\administration\news.php on line 302
Delete
Notice: Undefined variable: news_image_t2 in U:\www\701rc3\administration\news.php on line 306
Solution.
Around line 199 find:
Code$news_image_t1 = (isset($_POST['news_image_t1']) ? $_POST['news_image_t1'] : "");
Add below it:
Code$news_image_t2 = (isset($_POST['news_image_t2']) ? $_POST['news_image_t2'] : "");
|
| |
|
|
| WEC |
Posted on 11-06-2010 17:16
|
Fusioneer

Posts: 1418
Joined: 22.10.05
|
administration\submissions.php
Notice on view submission:
Notice: Undefined index: user_status in U:\www\701rc3\administration\submissions.php on line 241
Solution.
Find:
Code $result = dbquery(
"SELECT ts.*, tu.user_id, tu.user_name, tu.user_level FROM ".DB_SUBMISSIONS." ts
LEFT JOIN ".DB_USERS." tu ON ts.submit_user=tu.user_id
WHERE submit_id='".$_GET['submit_id']."'"
);
Replace with:
Code $result = dbquery(
"SELECT ts.*, tu.user_id, tu.user_name, tu.user_level, tu.user_status FROM ".DB_SUBMISSIONS." ts
LEFT JOIN ".DB_USERS." tu ON ts.submit_user=tu.user_id
WHERE submit_id='".$_GET['submit_id']."'"
);
Same changes required for view submitted articles and submitted photos.
Edited by WEC on 11-06-2010 17:34 |
| |
|
|
| Fangree_Craig |
Posted on 11-06-2010 19:58
|
Veteran Member

Posts: 893
Joined: 27.09.05
|
Good Work WEC your doing really good at spotting these errors.
| Fangree Productions - Mods and Themes for PHP-Fusion 7 | |
| |
|
|
| starefossen |
Posted on 11-06-2010 22:42
|

Super Admin

Posts: 591
Joined: 09.02.06
|
@WEC: Thanks for excellent work. All the reported errors are fixed in revision 1662.
PHP-Fusion Development Team Leader
PHP-Fusion Codex - The complete reference to PHP-Fusion! |
| |
|
|
| gh0st2k |
Posted on 13-06-2010 12:50
|
Junior Member

Posts: 21
Joined: 23.11.08
|
Hi, here are some proposals to replace the "SELECT * QUERIES" (only BASEDIR).
There are a lot of "SELECT *" Queries in the admin section, i try to post some fixes for them.
gh0st2k attached the following file:
fusion_query.rar
Edited by gh0st2k on 13-06-2010 12:52 |
| |
|
|
| kneekoo |
Posted on 13-06-2010 21:33
|

Super Admin

Posts: 356
Joined: 20.01.06
|
Very good list, gh0st2k! Thank you. By the way, did you manually look for the "SELECT *" queries or you used a file searching tool?
Come visit PHP-Fusion Romania |
| |
|
|
| gh0st2k |
Posted on 13-06-2010 23:31
|
Junior Member

Posts: 21
Joined: 23.11.08
|
Search and highlite 
 |
| |
|
|
| gh0st2k |
Posted on 15-06-2010 12:40
|
Junior Member

Posts: 21
Joined: 23.11.08
|
and here is the next list...
gh0st2k attached the following file:
fusion_admin_query.rar |
| |
|
|
| MvE Designs |
Posted on 15-06-2010 22:39
|
Member

Posts: 59
Joined: 07.05.08
|
looks like gh0st2k is doing a good job  |
| |
|
|
| starefossen |
Posted on 16-06-2010 14:53
|

Super Admin

Posts: 591
Joined: 09.02.06
|
gh0st2k Nice, good work. Will be adding those and submit them with a bunch of other bug fixes to the SVN later tonight. Keep up the good work!
PHP-Fusion Development Team Leader
PHP-Fusion Codex - The complete reference to PHP-Fusion! |
| |
|
|
| MaWe4585 |
Posted on 16-06-2010 15:57
|
Junior Member

Posts: 12
Joined: 01.02.08
|
I get
Notice: Undefined index: user_status in E:\xampp\htdocs\phpfusion\administration\submissions.php on line 241
when i view submitted news submission in admin-module
edit: i tested a bit more:
Notice: Undefined index: user_status in E:\xampp\htdocs\phpfusion\administration\submissions.php on line 325
when i view submitted article submision
Notice: Undefined index: user_status in E:\xampp\htdocs\phpfusion\administration\submissions.php on line 427
when i view submitted photo submission
Edited by MaWe4585 on 16-06-2010 16:01 |
| |
|
|
| starefossen |
Posted on 16-06-2010 16:11
|

Super Admin

Posts: 591
Joined: 09.02.06
|
@MaWe4585: Thanks for reporting this, it has been fixed in latest SVN revision and will be present in next Release Candidate.
PHP-Fusion Development Team Leader
PHP-Fusion Codex - The complete reference to PHP-Fusion! |
| |
|